[
https://issues.apache.org/jira/browse/DRILL-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530571#comment-16530571
]
ASF GitHub Bot commented on DRILL-6410:
---------------------------------------
vrozov edited a comment on issue #1333: DRILL-6410: Memory leak in Parquet
Reader during cancellation
URL: https://github.com/apache/drill/pull/1333#issuecomment-401862300
@ilooner I guess by "last discussion" you refer to the discussion between
you, me and @sachouche, where "majority" does not mean the community majority.
In the Apache, any contributor can provide a solution that (s)he considers to
be the best solution possible and then it can either be accepted by the
community/contributor or blocked with -1 (requires technical justification). If
another contributor provides an alternative solution, a community may decide to
go with the alternate solution as long as it addresses technical concerns of
the initial contribution. For this particular case, my requirements are a) a
unified approach (@parthchandra has the same requirement) and b) the ability to
cancel tasks asynchronously. If that can be done with the approach outlined in
PR #1257 and a contributor will change it to address all the issues, let's move
forward with the alternate approach.
A note regarding the complexity of the implementation. This implementation
uses public java concurrency classes as well. It does not rely on unsupported
or unsafe to use Java classes and/or API. Basically, `LockSupport` is the same
first-class concurrency construct as `Thread` or `CountDownLatch` classes. The
primary use case for using those constructs is to create a combination of
`ExecutorService` and a `CountDownLatch` that is not provided by the Java
itself.
To summarize, I am perfectly fine to go with an alternate solution or with
another committer to review the PR, it will be against Apache way to force a
committer to review or commit a change, that (s)he is not comfortable with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Memory leak in Parquet Reader during cancellation
> -------------------------------------------------
>
> Key: DRILL-6410
> URL: https://issues.apache.org/jira/browse/DRILL-6410
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
>
> Occasionally, a memory leak is observed within the flat Parquet reader when
> query cancellation is invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
