[
https://issues.apache.org/jira/browse/DRILL-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538805#comment-16538805
]
ASF GitHub Bot commented on DRILL-6516:
---------------------------------------
parthchandra commented on a change in pull request #1358: DRILL-6516: EMIT
support in streaming agg
URL: https://github.com/apache/drill/pull/1358#discussion_r201169753
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
##########
@@ -496,6 +620,30 @@ private void getIndex(ClassGenerator<StreamingAggregator>
g) {
}
}
+ private IterOutcome getFinalOutcome() {
+ IterOutcome outcomeToReturn;
+
+ if(firstBatchForDataSet) {
+ firstBatchForDataSet = false;
+ }
+ if (firstBatchForSchema) {
+ outcomeToReturn = OK_NEW_SCHEMA;
+ firstBatchForSchema = false;
+ } else if (recordCount == 0) {
+ // get the outcome to return before calling refresh since that resets
the lastKnowOutcome to OK
+ outcomeToReturn = lastKnownOutcome == EMIT ? EMIT : NONE;
+ if (outcomeToReturn == EMIT) {
+ firstBatchForDataSet = true;
+ }
+ } else if (lastKnownOutcome == EMIT) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support for EMIT outcome in streaming agg
> -----------------------------------------
>
> Key: DRILL-6516
> URL: https://issues.apache.org/jira/browse/DRILL-6516
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Parth Chandra
> Assignee: Parth Chandra
> Priority: Major
> Fix For: 1.14.0
>
>
> Update the streaming aggregator to recognize the EMIT outcome
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
