[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538838#comment-16538838
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r201399120
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetMetaStatCollector.java
##########
@@ -59,7 +59,7 @@ public ParquetMetaStatCollector(ParquetTableMetadataBase
parquetTableMetadata,
// Reasons to pass implicit columns and their values:
// 1. Differentiate implicit columns from regular non-exist columns.
Implicit columns do not
// exist in parquet metadata. Without such knowledge, implicit columns
is treated as non-exist
- // column. A condition on non-exist column would lead to canDrop =
true, which is not the
+ // column. A condition on non-exist column would lead to matches =
true, which is not the
Review comment:
The same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
