[
https://issues.apache.org/jira/browse/DRILL-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540056#comment-16540056
]
ASF GitHub Bot commented on DRILL-5797:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1370: DRILL-5797: Use
Parquet new reader in all non-complex column queries
URL: https://github.com/apache/drill/pull/1370#discussion_r201676752
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
##########
@@ -107,7 +105,9 @@ protected ScanBatch getBatch(ExecutorFragmentContext
context, AbstractParquetRow
ParquetReaderUtility.detectCorruptDates(footer,
rowGroupScan.getColumns(), autoCorrectCorruptDates);
logger.debug("Contains corrupt dates: {}", containsCorruptDates);
- if
(!context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER) &&
!isComplex(footer)) {
+ if
(!context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER)
+ && !ParquetReaderUtility.containsComplexColumn(footer,
rowGroupScan.getColumns())) {
+ logger.debug("Query qualifies for new Parquet reader");
Review comment:
Which query? We might add query id or something to help identification in
the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use more often the new parquet reader
> -------------------------------------
>
> Key: DRILL-5797
> URL: https://issues.apache.org/jira/browse/DRILL-5797
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Oleksandr Kalinin
> Priority: Major
> Fix For: 1.15.0
>
>
> The choice of using the regular parquet reader of the optimized one is based
> of what type of columns is in the file. But the columns that are read by the
> query doesn't matter. We can increase a little bit the cases where the
> optimized reader is used by checking is the projected column are simple or
> not.
> This is an optimization waiting for the fast parquet reader to handle complex
> structure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
