[
https://issues.apache.org/jira/browse/DRILL-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540267#comment-16540267
]
ASF GitHub Bot commented on DRILL-6560:
---------------------------------------
sachouche commented on a change in pull request #1355: DRILL-6560: Enhanced the
batch statistics logging enablement
URL: https://github.com/apache/drill/pull/1355#discussion_r201511586
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -704,5 +704,8 @@ public static String bootDefaultFor(String name) {
public static final String STATS_LOGGING_FG_BATCH_SIZE_OPTION =
"drill.exec.stats.logging.fine_grained.batch_size";
public static final BooleanValidator STATS_LOGGING_BATCH_FG_SIZE_VALIDATOR =
new BooleanValidator(STATS_LOGGING_FG_BATCH_SIZE_OPTION);
+ /** Controls the list of operators for which batch sizing stats should be
enabled */
Review comment:
Agree that "enabled_operators" is a better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow options for controlling the batch size per operator
> ---------------------------------------------------------
>
> Key: DRILL-6560
> URL: https://issues.apache.org/jira/browse/DRILL-6560
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> This Jira is for internal Drill DEV use; the following capabilities are
> needed for automating the batch sizing functionality testing:
> * Control the enablement of batch sizing statistics at session (per query)
> and server level (all queries)
> * Control the granularity of batch sizing statistics (summary or verbose)
> * Control the set of operators that should log batch statistics
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
