[
https://issues.apache.org/jira/browse/DRILL-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546046#comment-16546046
]
ASF GitHub Bot commented on DRILL-6179:
---------------------------------------
paul-rogers commented on a change in pull request #1126: DRILL-6179: Added
pcapng-format support
URL: https://github.com/apache/drill/pull/1126#discussion_r202895303
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/schema/Schema.java
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.pcapng.schema;
+
+import org.apache.drill.exec.store.pcapng.schema.columns.Column;
+import org.apache.drill.exec.store.pcapng.schema.columns.DstIpImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.DstMacImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.DstPortImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.PacketDataImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.PacketLenImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.SrcIpImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.SrcMacImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.SrcPortImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpAckImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlags;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsAckImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsCwrImpl;
+import
org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsEceCongestionExperiencedImpl;
+import
org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsEceEcnCapableImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsEceImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsFinImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsNsImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsPshImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsRstImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsSynImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpFlagsUrgIml;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpParsedFlags;
+import org.apache.drill.exec.store.pcapng.schema.columns.TcpSessionImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TimestampImpl;
+import org.apache.drill.exec.store.pcapng.schema.columns.TypeImpl;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
+
+public class Schema {
+
+ private final static Map<String, Column> columns = new HashMap<>();
+
+ static {
+ columns.put("timestamp", new TimestampImpl());
Review comment:
Minor style issue. You can go ahead and include the `Impl` classes here as
`static` nested classes. Puts all this tightly-coupled code in one easy place;
makes it easier for readers.
Having each `Impl` in its own file is also fine, just a bit harder to read
through many small files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Added pcapng-format support
> ---------------------------
>
> Key: DRILL-6179
> URL: https://issues.apache.org/jira/browse/DRILL-6179
> Project: Apache Drill
> Issue Type: New Feature
> Affects Versions: 1.13.0
> Reporter: Vlad
> Assignee: Vlad
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> The _PCAP Next Generation Dump File Format_ (or pcapng for short) [1] is an
> attempt to overcome the limitations of the currently widely used (but
> limited) libpcap format.
> At a first level, it is desirable to query and filter by source and
> destination IP and port, and src/dest mac addreses or by protocol. Beyond
> that, however, it would be very useful to be able to group packets by TCP
> session and eventually to look at packet contents.
> Initial work is available at
> https://github.com/mapr-demos/drill/tree/pcapng_dev
> [1] https://pcapng.github.io/pcapng/
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
