[
https://issues.apache.org/jira/browse/DRILL-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549353#comment-16549353
]
ASF GitHub Bot commented on DRILL-6613:
---------------------------------------
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor
MaterializedField
URL: https://github.com/apache/drill/pull/1383#discussion_r203752120
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -792,7 +792,7 @@ private void setupOutputContainerSchema() {
}
// make sure to project field with children for children to show up in
the schema
- final MaterializedField projected = field.withType(outputType);
+ final MaterializedField projected = field.copy(outputType);
Review comment:
In such case one of the `copy` should be named `copyWithNameAndType`. As
parameters already provide a hint that `name` and/or `type` will be changed I
don't see much need to use the method name for the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor MaterializedField
> --------------------------
>
> Key: DRILL-6613
> URL: https://issues.apache.org/jira/browse/DRILL-6613
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
>
> {{MaterializedField}} does not need to implement {{clone()}} and should use
> constructor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
