[jira] [Commented] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission

[Bob Rudis (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552743#comment-16552743
 ] 

Bob Rudis commented on DRILL-6611:
----------------------------------

Per code review requirement #4 I suspect I should ask [~kkhatua] (who is 
already in-thread) or [~sudheeshkatkam] to review the PR before I then do #5 
which is set the reviewer field. (first contribution so am meticulously working 
through the steps in the docs…apologies for any verbosity as a result).

> Add [meta]-[Enter] js handler for query form submission
> -------------------------------------------------------
>
>                 Key: DRILL-6611
>                 URL: https://issues.apache.org/jira/browse/DRILL-6611
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.14.0
>            Reporter: Bob Rudis
>            Assignee: Bob Rudis
>            Priority: Minor
>             Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form 
> without using a mouse would be even better.
> Adding:
>  
> {noformat}
> document.getElementById('queryForm')
>  .addEventListener('keydown', function(e) {
>  if (!(e.keyCode == 13 && e.metaKey)) return;
>  if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such 
> support.}}
> I can file a PR with the code if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)