[
https://issues.apache.org/jira/browse/DRILL-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559287#comment-16559287
]
ASF GitHub Bot commented on DRILL-6616:
---------------------------------------
sohami commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205626233
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java
##########
@@ -36,9 +36,12 @@
import static
org.apache.drill.exec.record.BatchSchema.SelectionVectorMode.NONE;
/**
- * Contains the actual unnest operation. Unnest is a simple transfer operation
in this impelementation.
+ * Contains the actual unnest operation. Unnest is a simple transfer operation
in this implementation.
* For use as a table function, we will need to change the logic of the unnest
method to operate on
* more than one row at a time and remove any dependence on Lateral
+ * Additionally, unnest produces an implicit rowId column that allows unnest
to output batches with many
+ * rows of incoming data being unnested in a single call to innerNext().
Downstream blocking operators need
+ * to be aware of this rowId column and include the rowId a sort or group by
key.
Review comment:
include the rowId **a** --> as
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch Processing for Lateral/Unnest
> -----------------------------------
>
> Key: DRILL-6616
> URL: https://issues.apache.org/jira/browse/DRILL-6616
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement the execution and planner side changes for the batch processing
> done by lateral and unnest. Based on the prototype we found performance to be
> much better as compared to initial row-by-row execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
