[
https://issues.apache.org/jira/browse/DRILL-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565843#comment-16565843
]
ASF GitHub Bot commented on DRILL-6461:
---------------------------------------
sachouche commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r206995312
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
##########
@@ -1175,6 +1175,7 @@ public AggIterOutcome outputCurrentBatch() {
v.getValueVector().getMutator().setValueCount(numOutputRecords);
}
+ outContainer.setRecordCount(numOutputRecords);
Review comment:
I noticed the Drill code has three places where to set the record count;
within a:
- RecordBatch object (look at ScanBatch)
- VectorContainer
- Individual vectors
Can we centralize this to a utility so that setting the count is always
consistent across all operators. I am not suggesting that you do that within
this PR (as I don't want to extend its scope) but this is just to get some
feedback about this behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Basic Data Correctness Unit Tests
> -------------------------------------
>
> Key: DRILL-6461
> URL: https://issues.apache.org/jira/browse/DRILL-6461
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
> There are no data correctness unit tests for HashAgg. We need to add some.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
