[
https://issues.apache.org/jira/browse/DRILL-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574611#comment-16574611
]
ASF GitHub Bot commented on DRILL-6656:
---------------------------------------
vvysotskyi commented on a change in pull request #1415: DRILL-6656: Disallow
extra semicolons in import statements.
URL: https://github.com/apache/drill/pull/1415#discussion_r208868830
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
##########
@@ -302,9 +302,12 @@ private LogicalExpression
getDrillCastFunctionFromOptiq(RexCall call){
castType =
Types.required(MinorType.VARCHAR).toBuilder().setPrecision(call.getType().getPrecision()).build();
break;
- case "INTEGER": castType = Types.required(MinorType.INT); break;
- case "FLOAT": castType = Types.required(MinorType.FLOAT4); break;
- case "DOUBLE": castType = Types.required(MinorType.FLOAT8); break;
+ case "INTEGER": castType = Types.required(MinorType.INT);
Review comment:
Could you please move the assigning to the next line here and in this class
below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Regex To Disallow Extra Semicolons In Imports
> -------------------------------------------------
>
> Key: DRILL-6656
> URL: https://issues.apache.org/jira/browse/DRILL-6656
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.15.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
