[
https://issues.apache.org/jira/browse/DRILL-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579675#comment-16579675
]
ASF GitHub Bot commented on DRILL-5735:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1279: DRILL-5735: Allow
search/sort in the Options webUI
URL: https://github.com/apache/drill/pull/1279#discussion_r209916401
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ExtendedOptionIterator.java
##########
@@ -134,19 +168,36 @@ public ExtendedOptionValueWrapper next() {
*/
public static class ExtendedOptionValueWrapper {
+ private static final String SHORT_DESCRIPTION_SUFFIX = ".short";
+ private static final int SHORT_DESCRIP_MAX_SIZE = 110;
public final String name;
public final String kind;
public final OptionValue.AccessibleScopes accessibleScopes;
public final String val;
+ public final Status status;
public final OptionScope optionScope;
+ public final String description;
-
- public ExtendedOptionValueWrapper(final String name, final String kind,
final OptionValue.AccessibleScopes type, final String value, final OptionScope
scope) {
+ public ExtendedOptionValueWrapper(final String name, final String kind,
final OptionValue.AccessibleScopes type, final String value, final Status
status, final OptionScope scope) {
this.name = name;
this.kind = kind;
this.accessibleScopes = type;
this.val = value;
+ this.status = status;
this.optionScope = scope;
+ this.description = getShortDescription(name);
+ }
+
+ private String getShortDescription(String name) {
Review comment:
Has comment been added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> UI options grouping and filtering & Metrics hints
> -------------------------------------------------
>
> Key: DRILL-5735
> URL: https://issues.apache.org/jira/browse/DRILL-5735
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0, 1.10.0, 1.11.0
> Reporter: Muhammad Gelbana
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.15.0
>
>
> I'm thinking of some UI improvements that could make all the difference for
> users trying to optimize low-performing queries.
> h2. Options
> h3. Grouping
> We can organize the options to be grouped by their scope of effect, this will
> help users easily locate the options they may need to tune.
> h3. Filtering
> Since the options are a lot, we can add a filtering mechanism (i.e. string
> search or group\scope filtering) so the user can filter out the options he's
> not interested in. To provide more benefit than the grouping idea mentioned
> above, filtering may include keywords also and not just the option name,
> since the user may not be aware of the name of the option he's looking for.
> h2. Metrics
> I'm referring here to the metrics page and the query execution plan page that
> displays the overview section and major\minor fragments metrics. We can show
> hints for each metric such as:
> # What does it represent in more details.
> # What option\scope-of-options to tune (increase ? decrease ?) to improve the
> performance reported by this metric.
> # May be even provide a small dialog to quickly allow the modification of the
> related option(s) to that metric
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
