[
https://issues.apache.org/jira/browse/DRILL-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580454#comment-16580454
]
ASF GitHub Bot commented on DRILL-6687:
---------------------------------------
parthchandra commented on a change in pull request #1431: DRILL-6687: Improve
RemovingRecordBatch to do transfer when all recor…
URL: https://github.com/apache/drill/pull/1431#discussion_r210105705
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java
##########
@@ -37,6 +37,7 @@
private final BufferAllocator allocator;
private int recordCount;
+ private int batchActualRecordCount = -1;
Review comment:
put a comment to differentiate between recordCount and batchActualRecordCount
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve RemovingRecordBatch to do transfer when all records needs to be copied
> ------------------------------------------------------------------------------
>
> Key: DRILL-6687
> URL: https://issues.apache.org/jira/browse/DRILL-6687
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> SelectionVector2 contains list of indexes for the rows that
> RemovingRecordBatch can copy from underlying RecordBatch. SV2 is created by
> operator like Filter, Limit, etc to provide the selected rows from underlying
> buffer. Later then RemovingRecordBatch copies the rows based on indexes in
> SelectionVector2 to the output container of type NONE.
> For cases when all the rows needs to be copied by RemovingRecordBatch from
> incoming batch, it can be improved to do full transfer of ValueVectors from
> input to output container instead of row by row copy. For example if for an
> incoming batch all rows are selected by the Filter condition in
> FilterRecordBatch, it will prepare an SV2 with all the record rowIndex. Later
> RemovingRecordBatch downstream of Filter can potentially do just transfer
> instead of row by row copy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
