[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583897#comment-16583897
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace
usage of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r210889890
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java
##########
@@ -77,12 +77,9 @@ public FunctionExprNode(String function, List<ExprNode>
args) {
@Override
public String toString() {
- StringBuilder builder = new StringBuilder();
- builder.append(function);
- builder.append("(");
- builder.append(Joiner.on(",").join(args));
- builder.append(")");
- return builder.toString();
+ return function + args.stream()
+ .map(ExprNode::toString)
+ .collect(Collectors.joining(",", "(", ")"));
Review comment:
Adding a space here may cause failures of tests with checks for the query
plan. You may create a Jira for further improvement of the output, but I don't
think that we should do it in the scope of this Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
