[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583891#comment-16583891
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace
usage of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r210888793
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
##########
@@ -242,7 +241,7 @@ public String getAdminUserGroups(OptionManager
optionManager) {
// if this option has not been changed by the user then return the
// process user groups
if (adminUserGroups.equals(DEFAULT_ADMIN_USER_GROUPS)) {
- adminUserGroups =
Joiner.on(",").join(ImpersonationUtil.getProcessUserGroupNames());
+ adminUserGroups = String.join(",",
ImpersonationUtil.getProcessUserGroupNames());
Review comment:
If you meant a comma inside the string literal, then I doubt that space will
be useful there, since the result of this method is often split by `","`. So I
leave it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
