[
https://issues.apache.org/jira/browse/DRILL-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584455#comment-16584455
]
ASF GitHub Bot commented on DRILL-6461:
---------------------------------------
ilooner commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r211046248
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/AbstractGenericCopierTest.java
##########
@@ -20,77 +20,106 @@
import org.apache.drill.common.types.TypeProtos;
import org.apache.drill.common.types.Types;
import org.apache.drill.exec.exception.SchemaChangeException;
-import org.apache.drill.exec.memory.RootAllocator;
+import org.apache.drill.exec.memory.BufferAllocator;
+import org.apache.drill.exec.physical.impl.MockRecordBatch;
import org.apache.drill.exec.record.BatchSchema;
import org.apache.drill.exec.record.MaterializedField;
import org.apache.drill.exec.record.RecordBatch;
import org.apache.drill.exec.record.VectorContainer;
-import org.apache.drill.exec.record.metadata.TupleMetadata;
+import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.vector.SchemaChangeCallBack;
+import org.apache.drill.test.BaseDirTestWatcher;
+import org.apache.drill.test.OperatorFixture;
+import org.apache.drill.test.rowSet.DirectRowSet;
import org.apache.drill.test.rowSet.RowSet;
-import org.apache.drill.test.rowSet.RowSetBatch;
import org.apache.drill.test.rowSet.RowSetBuilder;
import org.apache.drill.test.rowSet.RowSetComparison;
import org.apache.drill.test.rowSet.schema.SchemaBuilder;
+import org.junit.Rule;
import org.junit.Test;
public abstract class AbstractGenericCopierTest {
+ @Rule
+ public final BaseDirTestWatcher baseDirTestWatcher = new
BaseDirTestWatcher();
+
@Test
- public void testCopyRecords() throws SchemaChangeException {
- try (RootAllocator allocator = new RootAllocator(10_000_000)) {
- final TupleMetadata batchSchema =
createTestSchema(BatchSchema.SelectionVectorMode.NONE);
+ public void testCopyRecords() throws Exception {
+ try (OperatorFixture operatorFixture = new
OperatorFixture.Builder(baseDirTestWatcher).build()) {
+ final BufferAllocator allocator = operatorFixture.allocator();
+ final BatchSchema batchSchema =
createTestSchema(BatchSchema.SelectionVectorMode.NONE);
final RowSet srcRowSet = createSrcRowSet(allocator);
- final RowSet destRowSet = new RowSetBuilder(allocator,
batchSchema).build();
- final VectorContainer destContainer = destRowSet.container();
- final Copier copier = createCopier(new RowSetBatch(srcRowSet),
destContainer, null);
+ final VectorContainer destContainer = new VectorContainer(allocator,
batchSchema);
+
+ for (VectorWrapper vectorWrapper: destContainer) {
+ vectorWrapper.getValueVector().allocateNew();
Review comment:
Thanks for catching this. I've moved the allocation code into a static
method and call it in GenericCopier.copyRecords.
It is still necessary to allocate the vectors in the appendRecords test
though, since appendRecords assumes the vector container is pre existing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Basic Data Correctness Unit Tests
> -------------------------------------
>
> Key: DRILL-6461
> URL: https://issues.apache.org/jira/browse/DRILL-6461
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
> There are no data correctness unit tests for HashAgg. We need to add some.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
