[
https://issues.apache.org/jira/browse/DRILL-6676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584780#comment-16584780
]
ASF GitHub Bot commented on DRILL-6676:
---------------------------------------
ppadma commented on a change in pull request #1429: DRILL-6676: Add Union, List
and Repeated List types to Result Set Loader
URL: https://github.com/apache/drill/pull/1429#discussion_r211064165
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/BuildFromSchema.java
##########
@@ -60,17 +90,23 @@ public ObjectWriter add(ColumnMetadata colSchema) {
*/
public void buildTuple(TupleWriter writer, TupleMetadata schema) {
- ParentShim tupleShim = new TupleShim(writer);
+ final ParentShim tupleShim = new TupleShim(writer);
for (int i = 0; i < schema.size(); i++) {
- ColumnMetadata colSchema = schema.metadata(i);
+ final ColumnMetadata colSchema = schema.metadata(i);
buildColumn(tupleShim, colSchema);
}
}
private void buildColumn(ParentShim parent, ColumnMetadata colSchema) {
- if (colSchema.isMap()) {
+ if (colSchema.structureType() == StructureType.MULTI_ARRAY) {
Review comment:
can we have isMultiArray method ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Union, List and Repeated List types to Result Set Loader
> ------------------------------------------------------------
>
> Key: DRILL-6676
> URL: https://issues.apache.org/jira/browse/DRILL-6676
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.15.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.15.0
>
>
> Add support for the "obscure" vector types to the {{ResultSetLoader}}:
> * Union
> * List
> * Repeated List
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
