[
https://issues.apache.org/jira/browse/DRILL-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589237#comment-16589237
]
ASF GitHub Bot commented on DRILL-6647:
---------------------------------------
HanumathRao commented on a change in pull request #1425: DRILL-6647: Update
Calcite version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212064539
##########
File path: exec/java-exec/src/main/codegen/data/Parser.tdd
##########
@@ -85,13 +85,17 @@
# List of methods for parsing extensions to "DROP" calls.
# Each must accept arguments "(SqlParserPos pos)".
- dropStatementParserMethods: [
+ dropStatementParserMethods: [
]
# List of keywords from "keywords" section that are not reserved.
- nonReservedKeywords: [
+ nonReservedKeywords: [
]
+ # List of additional join types. Each is a method with no arguments.
Review comment:
I am not clear as to why are these changes required for the upgrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Calcite version to 1.17.0
> --------------------------------
>
> Key: DRILL-6647
> URL: https://issues.apache.org/jira/browse/DRILL-6647
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Upgrade to Calcite 1.17 version.
> From the upgrade to Calcite 1.16, several commits were left in Drill-Calcite
> fork. Since no additional work was done to move those commits from the fork,
> they will be placed on top of Calcite 1.17.
> Status from the upgrade to 1.15:
>
> [https://docs.google.com/document/d/1Lqk9NoKQviz0YimBmov4z1pui7QjJGjDVwMa1p0emPk/edit#heading=h.i3rowg20vxv4]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
