[
https://issues.apache.org/jira/browse/DRILL-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589950#comment-16589950
]
ASF GitHub Bot commented on DRILL-6647:
---------------------------------------
vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update
Calcite version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212235501
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java
##########
@@ -65,107 +65,52 @@ private void throwIfClosed() throws
AlreadyClosedSqlException {
// called ResultSet.)
@Override
- public DrillConnectionImpl getConnection() {
- // Can't throw any SQLException because AvaticaConnection's
getConnection() is
- // missing "throws SQLException".
- try {
- throwIfClosed();
- } catch (AlreadyClosedSqlException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ public DrillConnectionImpl getConnection() throws SQLException {
+ checkOpen();
return connection;
}
- // WORKAROUND: Work around AvaticaStatement's code that wraps _any_
exception,
- // even if SQLException, by unwrapping to get cause exception so caller can
- // throw it directly if it's a SQLException:
- // TODO: Any ideas for a better name?
- private SQLException unwrapIfExtra( final SQLException superMethodException
) {
Review comment:
Exactly this method is not required since now we don't wrap `SQLException`
exceptions into `SQLException`. Other methods, as I mentioned in the previous
comment, methods in Avatica have a check for connection is open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Calcite version to 1.17.0
> --------------------------------
>
> Key: DRILL-6647
> URL: https://issues.apache.org/jira/browse/DRILL-6647
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Upgrade to Calcite 1.17 version.
> From the upgrade to Calcite 1.16, several commits were left in Drill-Calcite
> fork. Since no additional work was done to move those commits from the fork,
> they will be placed on top of Calcite 1.17.
> Status from the upgrade to 1.15:
>
> [https://docs.google.com/document/d/1Lqk9NoKQviz0YimBmov4z1pui7QjJGjDVwMa1p0emPk/edit#heading=h.i3rowg20vxv4]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
