[
https://issues.apache.org/jira/browse/DRILL-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596504#comment-16596504
]
ASF GitHub Bot commented on DRILL-6717:
---------------------------------------
oleg-zinovev commented on a change in pull request #1450: DRILL-6717: lower and
upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213732578
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
##########
@@ -1441,11 +1442,12 @@ public void testUpper() throws Exception {
"upper('AbC aBc') as col_space,\n" +
"upper('123ABC$!abc123.') as col_special,\n" +
"upper('') as col_empty,\n" +
- "upper(cast(null as varchar(10))) as col_null\n" +
+ "upper(cast(null as varchar(10))) as col_null,\n" +
+ "upper('привет, мир!') as col_national\n" +
Review comment:
@Ben-Zvi
The test works, but I'm confused by the reason:
`ß` - 2 byte character, converting it to the upper case returns 2
single-byte `S` characters. Are there any other examples of such symbols?
@arina-ielchiieva
Initcap fixed too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> lower and upper functions not works with national charactes
> -----------------------------------------------------------
>
> Key: DRILL-6717
> URL: https://issues.apache.org/jira/browse/DRILL-6717
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Oleg Zinoviev
> Assignee: Oleg Zinoviev
> Priority: Major
> Fix For: 1.15.0
>
> Attachments: result.csv, sample.json
>
>
> upper() and lower() functions works only with a ascii characters.
> sample dataset: [^sample.json]
> query:
> {code:sql}
> select
> upper(ascii_l) as upper_ascii,
> upper(national_l) as upper_national,
> lower(ascii_u) as lower_ascii,
> lower(national_u) as lower_national
> from dfs.`sample.json`
> {code}
> drill response: [^result.csv]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
