[ 
https://issues.apache.org/jira/browse/DRILL-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603495#comment-16603495
 ] 

ASF GitHub Bot commented on DRILL-6724:
---------------------------------------

vdiravka commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds 
exception to UserException with …
URL: https://github.com/apache/drill/pull/1455#issuecomment-418492480
 
 
   @KazydubB It would be useful to show the use case how the error was 
displayed and how it is changed after these changes. Without any real use case 
it is not clear whether it is necessary. Please find some cases to show the 
additional info in Exception message and post it in Jira description.
   Also as I have mentioned, to go further with these changes it is necessary 
to have a unit test with verifying the new Exception content.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Convert IndexOutOfBounds exception to UserException with context data where 
> possible
> ------------------------------------------------------------------------------------
>
>                 Key: DRILL-6724
>                 URL: https://issues.apache.org/jira/browse/DRILL-6724
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.14.0
>            Reporter: Bohdan Kazydub
>            Assignee: Bohdan Kazydub
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Sometimes when IndexOutOfBoundsException is exposed to users it is not clear 
> what causes the problem. Instead this exception may be converted to a more 
> useful UserException containing context data like filename, line, position 
> etc (depending on what is available from a reader for a given type).
> A possible approach is to add a method to a RecordReader interface which 
> produces UserException of type ErrorType.DATA_READ with context data, so that 
> when such an UserException is needed it can be easily obtained by invoking 
> the method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to