[
https://issues.apache.org/jira/browse/DRILL-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610438#comment-16610438
]
ASF GitHub Bot commented on DRILL-6733:
---------------------------------------
vdiravka commented on issue #1464: DRILL-6733: Unit tests from
KafkaFilterPushdownTest are failing in so…
URL: https://github.com/apache/drill/pull/1464#issuecomment-420233907
I have BUILD SUCCESS with this solution after `mvn test -pl
contrib/storage-kafka` with 1, 2 and 3 number of `-DforkCount`.
I think the design of `TestKafkaSuit` could be improved to avoid such kind
of issues. But with current design the solution looks good.
@aravi5 Do you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unit tests from KafkaFilterPushdownTest are failing in some environments.
> -------------------------------------------------------------------------
>
> Key: DRILL-6733
> URL: https://issues.apache.org/jira/browse/DRILL-6733
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0, 1.15.0
> Reporter: Anton Gozhiy
> Assignee: Abhishek Ravi
> Priority: Major
>
> *Steps:*
> # Build the Drill project without skipping the unit tests:
> {noformat}
> mvn clean install
> {noformat}
> Alternatively, if the project was already built, run tests for Kafka:
> {noformat}
> mvn test -pl contrib/storage-kafka
> {noformat}
> *Expected results:*
> All tests are passed.
> *Actual results:*
> Tests from KafkaFilterPushdownTest are failing:
> {noformat}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed:
> -1,283,514.348 sec - in org.apache.drill.exec.store.kafka.MessageIteratorTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed:
> -1,283,513.783 sec - in org.apache.drill.exec.store.kafka.KafkaQueriesTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: -1,283,512.35
> sec - in org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest
> Running org.apache.drill.exec.store.kafka.decoders.MessageReaderFactoryTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.051 sec -
> in org.apache.drill.exec.store.kafka.decoders.MessageReaderFactoryTest
> Running org.apache.drill.exec.store.kafka.KafkaQueriesTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 152.2 sec -
> in org.apache.drill.exec.store.kafka.KafkaQueriesTest
> Running org.apache.drill.exec.store.kafka.MessageIteratorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.036 sec -
> in org.apache.drill.exec.store.kafka.MessageIteratorTest
> Running org.apache.drill.exec.store.kafka.decoders.MessageReaderFactoryTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.611 sec -
> in org.apache.drill.exec.store.kafka.decoders.MessageReaderFactoryTest
> Running org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest
> 13:09:29.511 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 213
> B(139.3 KiB), h: 20.0 MiB(719.0 MiB), nh: 794.5 KiB(120.1 MiB)):
> testPushdownWithOr(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> java.lang.AssertionError: expected:<26> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithOr(KafkaFilterPushdownTest.java:259)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:09:33.307 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 377
> B(139.7 KiB), h: 18.5 MiB(743.2 MiB), nh: 699.5 KiB(120.9 MiB)):
> testPushdownWithAndOrCombo2(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<4> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithAndOrCombo2(KafkaFilterPushdownTest.java:316)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:09:44.424 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0
> B(139.7 KiB), h: 11.7 MiB(774.6 MiB), nh: 537.1 KiB(122.3 MiB)):
> testPushdownOnTimestamp(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<20> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnTimestamp(KafkaFilterPushdownTest.java:92)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:09:48.162 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0
> B(139.7 KiB), h: 13.3 MiB(787.9 MiB), nh: 379.9 KiB(122.7 MiB)):
> testPushdownOnOffset(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnOffset(KafkaFilterPushdownTest.java:60)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:09:52.392 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 137
> B(139.8 KiB), h: 13.0 MiB(800.9 MiB), nh: 467.9 KiB(123.2 MiB)):
> testPushdownWithOr1(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<10> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithOr1(KafkaFilterPushdownTest.java:277)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:10:03.534 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0
> B(140.0 KiB), h: 11.7 MiB(830.4 MiB), nh: 301.0 KiB(124.2 MiB)):
> testPushdownUnorderedTimestamp(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownUnorderedTimestamp(KafkaFilterPushdownTest.java:109)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:10:07.359 [main] ERROR org.apache.drill.TestReporter - Test Failed (d:
> -1.0 KiB(139.0 KiB), h: -384.1 MiB(446.3 MiB), nh: 329.7 KiB(124.6 MiB)):
> testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafk
> a.KafkaFilterPushdownTest)
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOffsetOneRecordReturnedWithBoundaryConditions(KafkaFilterPushdownTest.java:227)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:10:11.134 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 3
> B(139.0 KiB), h: 17.1 MiB(463.4 MiB), nh: 495.3 KiB(125.1 MiB)):
> testPushdownWithAndOrCombo(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<8> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithAndOrCombo(KafkaFilterPushdownTest.java:296)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> 13:10:59.388 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0
> B(139.0 KiB), h: 7.5 MiB(578.8 MiB), nh: 304.2 KiB(128.2 MiB)):
> testPushdownOnPartition(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
>
> java.lang.AssertionError: expected:<10> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
> ~[test-classes/:na]
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnPartition(KafkaFilterPushdownTest.java:76)
> ~[test-classes/:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_181]
> Tests run: 15, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 2,582.537
> sec <<< FAILURE! - in
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest
> testPushdownWithOr(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.753 sec <<< FAILURE!
> java.lang.AssertionError: expected:<26> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithOr(KafkaFilterPushdownTest.java:259)
>
> testPushdownWithAndOrCombo2(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.79 sec <<< FAILURE!
> java.lang.AssertionError: expected:<4> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithAndOrCombo2(KafkaFilterPushdownTest.java:316)
>
> testPushdownOnTimestamp(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.716 sec <<< FAILURE!
> java.lang.AssertionError: expected:<20> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnTimestamp(KafkaFilterPushdownTest.java:92)
>
> testPushdownOnOffset(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.741 sec <<< FAILURE!
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnOffset(KafkaFilterPushdownTest.java:60)
>
> testPushdownWithOr1(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 4.227 sec <<< FAILURE!
> java.lang.AssertionError: expected:<10> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithOr1(KafkaFilterPushdownTest.java:277)
>
> testPushdownUnorderedTimestamp(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.721 sec <<< FAILURE!
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownUnorderedTimestamp(KafkaFilterPushdownTest.java:109)
>
> testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.831 sec <<< FAILURE!
> java.lang.AssertionError: expected:<5> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOffsetOneRecordReturnedWithBoundaryConditions(KafkaFilterPushdownTest.java:227)
>
> testPushdownWithAndOrCombo(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.769 sec <<< FAILURE!
> java.lang.AssertionError: expected:<8> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownWithAndOrCombo(KafkaFilterPushdownTest.java:296)
>
> testPushdownOnPartition(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest)
> Time elapsed: 3.96 sec <<< FAILURE!
> java.lang.AssertionError: expected:<10> but was:<0>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.logResultAndVerifyRowCount(KafkaTestBase.java:76)
>
> at
> org.apache.drill.exec.store.kafka.KafkaTestBase.runKafkaSQLVerifyCount(KafkaTestBase.java:69)
>
> at
> org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest.testPushdownOnPartition(KafkaFilterPushdownTest.java:76)
>
> Results :
> Failed tests:
>
> KafkaFilterPushdownTest.testPushdownWithOr:259->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<26> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownWithAndOrCombo2:316->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<4> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownOnTimestamp:92->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<20> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownOnOffset:60->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<5> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownWithOr1:277->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<10> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownUnorderedTimestamp:109->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<5> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownOffsetOneRecordReturnedWithBoundaryConditions:227->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<5> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownWithAndOrCombo:296->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<8> but was:<0>
>
> KafkaFilterPushdownTest.testPushdownOnPartition:76->KafkaTestBase.runKafkaSQLVerifyCount:69->KafkaTestBase.logResultAndVerifyRowCount:76
> expected:<10> but was:<0>
> Tests run: 35, Failures: 9, Errors: 0, Skipped: 3
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 46:02 min
> [INFO] Finished at: 2018-09-07T13:52:05+03:00
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
>
> *Workaround:* Increase the fork count:
> {noformat}
> mvn test -pl contrib/storage-kafka -DforkCount=3
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)