[ 
https://issues.apache.org/jira/browse/DRILL-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610980#comment-16610980
 ] 

ASF GitHub Bot commented on DRILL-3853:
---------------------------------------

arina-ielchiieva commented on a change in pull request #1462: DRILL-3853: 
Upgrade to SqlLine 1.5.0
URL: https://github.com/apache/drill/pull/1462#discussion_r216753976
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
 ##########
 @@ -70,6 +71,9 @@
      */
     GuavaPatcher.patch();
     Environment.logEnv("Drillbit environment: ", logger);
+    // Jersey uses java.util.logging - create bridge: jul to slf4j
+    SLF4JBridgeHandler.removeHandlersForRootLogger();
 
 Review comment:
   This was done to remove the following, especially when starting Drill in 
embedded mode.
   ```
   Sep 10, 2018 3:27:01 PM org.glassfish.jersey.server.ApplicationHandler 
initialize
   INFO: Initiating Jersey application, version Jersey: 2.8 2014-04-29 
01:25:26...
   ```
   I don't think we need Jersey info logs in Drill log, error will be logged as 
usual.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Get off Sqlline fork
> --------------------
>
>                 Key: DRILL-3853
>                 URL: https://issues.apache.org/jira/browse/DRILL-3853
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Parth Chandra
>            Assignee: Arina Ielchiieva
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Drill has it's own forked version of sqlline that includes customizations for 
> displaying the drill version, drill QOTD, removing names of unsupported 
> commands and removing JDBC drivers not shipped with Drill.
> To get off the fork, we need to parameterize these features in sqlline and 
> have them driven from a properties file. The changes should be merged back 
> into sqlline and Drill packaging should then provide a properties file to 
> customize the stock sqlline distribution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to