[ 
https://issues.apache.org/jira/browse/DRILL-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614315#comment-16614315
 ] 

ASF GitHub Bot commented on DRILL-6717:
---------------------------------------

Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not 
works with national characters
URL: https://github.com/apache/drill/pull/1450#issuecomment-421220397
 
 
   @oleg-zinovev - thank you for the thorough performance comparison.
   Though I'm confused - the graphs seem similar, but comparing the numbers 
from the log (I looked at the ops/s figure before the [Average]) seem to "jump 
around" - sometimes similar, sometimes double or more the other figure, with no 
clear "better" side.
   
   The other question was about "simple, standard code" vs. "complex code".  
The initial comment suggested using the simple code, unless the complex code 
has a significant performance advantage. 
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> lower and upper functions not works with national charactes
> -----------------------------------------------------------
>
>                 Key: DRILL-6717
>                 URL: https://issues.apache.org/jira/browse/DRILL-6717
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.14.0
>            Reporter: Oleg Zinoviev
>            Assignee: Oleg Zinoviev
>            Priority: Major
>             Fix For: 1.15.0
>
>         Attachments: result.csv, sample.json
>
>
> upper() and lower() functions works only with a ascii characters.
> sample dataset:  [^sample.json] 
> query:
> {code:sql}
> select 
>   upper(ascii_l) as upper_ascii, 
>   upper(national_l) as upper_national, 
>   lower(ascii_u) as lower_ascii, 
>   lower(national_u) as lower_national 
> from dfs.`sample.json`
> {code}
> drill response:  [^result.csv] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to