[
https://issues.apache.org/jira/browse/DRILL-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641784#comment-16641784
]
ASF GitHub Bot commented on DRILL-6765:
---------------------------------------
asfgit closed pull request #1486: DRILL-6765: Exclude unused shaded guava
classes from drill-jdbc-all jar
URL: https://github.com/apache/drill/pull/1486
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
index 7a6c9eeb0f8..cdd5dc9ce05 100644
--- a/exec/jdbc-all/pom.xml
+++ b/exec/jdbc-all/pom.xml
@@ -436,15 +436,14 @@
<exclude>codegen/**</exclude>
<exclude>bootstrap-storage-plugins.json</exclude>
<exclude>org/apache/parquet</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/math</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/graph</exclude>
- <exclude>org/apache/drill/shaded/com/google/common/net</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/primitives</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/reflect</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/util</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/cache</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/collect/Tree*</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/collect/Standard*</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/escape/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/eventbus/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/html/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/net/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/xml/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/graph/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/collect/Tree*</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/collect/Standard*</exclude>
<exclude>com/google/common/math</exclude>
<exclude>com/google/common/net</exclude>
<exclude>com/google/common/primitives</exclude>
@@ -751,15 +750,14 @@
<exclude>codegen/**</exclude>
<exclude>bootstrap-storage-plugins.json</exclude>
<exclude>org/apache/parquet</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/math</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/graph</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/net</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/primitives</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/reflect</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/util</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/cache</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/collect/Tree*</exclude>
-
<exclude>org/apache/drill/shaded/com/google/common/collect/Standard*</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/escape/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/eventbus/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/html/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/net/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/xml/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/graph/**</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/collect/Tree*</exclude>
+
<exclude>org/apache/drill/shaded/guava/com/google/common/collect/Standard*</exclude>
<exclude>com/google/common/math</exclude>
<exclude>com/google/common/net</exclude>
<exclude>com/google/common/primitives</exclude>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Exclude unused shaded guava classes from drill-jdbc-all jar
> -----------------------------------------------------------
>
> Key: DRILL-6765
> URL: https://issues.apache.org/jira/browse/DRILL-6765
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Igor Guzenko
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> {{drill-jdbc-all}} jar contains some classes and packages from shaded guava
> library ({{org/apache/drill/shaded/com/google/common}}) which weren't used
> anywhere in the project.
> The aim of this Jira is to determine those classes and packages and exclude
> them from the {{drill-jdbc-all}} jar since shaded guava is used by Drill only
> and there are no risks to get {{ClassNotFoundException}} from the transitive
> dependencies due to this change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
