[
https://issues.apache.org/jira/browse/DRILL-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645079#comment-16645079
]
ASF GitHub Bot commented on DRILL-6768:
---------------------------------------
KazydubB commented on a change in pull request #1494: DRILL-6768: Improve
to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r224026515
##########
File path: exec/java-exec/src/main/codegen/templates/CastVarCharInterval.java
##########
@@ -56,34 +65,41 @@ public void setup() {
}
public void eval() {
-
- byte[] buf = new byte[in.end - in.start];
- in.buffer.getBytes(in.start, buf, 0, in.end - in.start);
- String input = new String(buf, com.google.common.base.Charsets.UTF_8);
-
- // Parse the ISO format
- org.joda.time.Period period = org.joda.time.Period.parse(input);
-
- <#if type.to == "Interval">
- out.months = (period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths) + period.getMonths();
-
- out.days = period.getDays();
-
- out.milliseconds = (period.getHours() *
org.apache.drill.exec.vector.DateUtilities.hoursToMillis) +
- (period.getMinutes() *
org.apache.drill.exec.vector.DateUtilities.minutesToMillis) +
- (period.getSeconds() *
org.apache.drill.exec.vector.DateUtilities.secondsToMillis) +
- (period.getMillis());
-
- <#elseif type.to == "IntervalDay">
- out.days = period.getDays();
-
- out.milliseconds = (period.getHours() *
org.apache.drill.exec.vector.DateUtilities.hoursToMillis) +
- (period.getMinutes() *
org.apache.drill.exec.vector.DateUtilities.minutesToMillis) +
- (period.getSeconds() *
org.apache.drill.exec.vector.DateUtilities.secondsToMillis) +
- (period.getMillis());
- <#elseif type.to == "IntervalYear">
- out.value = (period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths) + period.getMonths();
- </#if>
+ <#if type.major == "EmptyStringVarCharIntervalComplex">
+ if(<#if type.from == "NullableVarChar" || type.from == "NullableVar16Char"
|| type.from == "NullableVarBinary">in.isSet == 0 || </#if>in.end == in.start) {
Review comment:
Sure, here is one for (required) VarChar (package and imports are excluded
for brevity):
```
@SuppressWarnings("unused")
@FunctionTemplate(name = "castEmptyStringVarCharToNULLABLEINTERVALYEAR",
scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls = NullHandling.INTERNAL)
public class CastEmptyStringVarCharToNullableIntervalYear implements
DrillSimpleFunc {
@Param VarCharHolder in;
@Output NullableIntervalYearHolder out;
public void setup() {
}
public void eval() {
if(in.end == in.start) {
out.isSet = 0;
return;
}
out.isSet = 1;
byte[] buf = new byte[in.end - in.start];
in.buffer.getBytes(in.start, buf, 0, in.end - in.start);
String input = new String(buf, com.google.common.base.Charsets.UTF_8);
// Parse the ISO format
org.joda.time.Period period = org.joda.time.Period.parse(input);
out.value = (period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths) + period.getMonths();
}
}
```
And for NullableVarChar
```
@SuppressWarnings("unused")
@FunctionTemplate(name =
"castEmptyStringNullableVarCharToNULLABLEINTERVALYEAR",
scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls = NullHandling.INTERNAL)
public class CastEmptyStringNullableVarCharToNullableIntervalYear implements
DrillSimpleFunc {
@Param NullableVarCharHolder in;
@Output NullableIntervalYearHolder out;
public void setup() {
}
public void eval() {
if(in.isSet == 0 || in.end == in.start) {
out.isSet = 0;
return;
}
out.isSet = 1;
byte[] buf = new byte[in.end - in.start];
in.buffer.getBytes(in.start, buf, 0, in.end - in.start);
String input = new String(buf, com.google.common.base.Charsets.UTF_8);
// Parse the ISO format
org.joda.time.Period period = org.joda.time.Period.parse(input);
out.value = (period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths) + period.getMonths();
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve to_date, to_time and to_timestamp and corresponding cast functions to
> handle empty string when `drill.exec.functions.cast_empty_string_to_null`
> option is enabled
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6768
> URL: https://issues.apache.org/jira/browse/DRILL-6768
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> When `drill.exec.functions.cast_empty_string_to_null` option is enabled
> `to_date`, `to_time` and `to_timestamp` functions while converting string to
> according type in case if null or empty string values are passed will return
> NULL (to avoid CASE clauses which are littering a query and will work in
> accordance with their respective CAST counterparts) for both cases.
>
>
>
> CASTs will be handled in a similar way (uniformly with numeric types):
>
> ||Value to cast||Now||Will be||
> |NULL|NULL|NULL|
> |'' (empty string)|Error in many cases (except numerical types)|NULL|
> CAST empty string to null (in case of enabled option) will be supported by
> DATE, TIME, TIMESTAMP, INTERVAL YEAR, INTERVAL MONTH and INTERVAL DAY
> functions in addition to numeric types.
>
> *For documentation*
> TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
