[
https://issues.apache.org/jira/browse/DRILL-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645385#comment-16645385
]
ASF GitHub Bot commented on DRILL-3988:
---------------------------------------
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r224191496
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/FunctionsIterator.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.sys;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.drill.exec.expr.fn.DrillFuncHolder;
+import org.apache.drill.exec.expr.fn.FunctionImplementationRegistry;
+import org.apache.drill.exec.expr.fn.registry.FunctionHolder;
+import org.apache.drill.exec.ops.ExecutorFragmentContext;
+import org.apache.drill.exec.store.pojo.NonNullable;
+
+/**
+ * List functions as a System Table
+ */
+public class FunctionsIterator implements Iterator<Object> {
+ //private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(FunctionsIterator.class);
+
+ private Iterator<FunctionInfo> sortedIterator;
+
+ public FunctionsIterator(ExecutorFragmentContext context) {
+ Map<String, FunctionInfo> functionMap = new HashMap<String,
FunctionInfo>();
+ //Access Registry for function list
+ FunctionImplementationRegistry funcImplRegistry =
(FunctionImplementationRegistry) context.getFunctionRegistry();
+ Map<String, List<FunctionHolder>> jarFunctionListMap =
funcImplRegistry.getAllJarsWithFunctionsHolders();
+ for (String jarName : new ArrayList<>(jarFunctionListMap.keySet())) {
+ for (FunctionHolder dfhEntry : jarFunctionListMap.get(jarName)) {
+ populateFunctionMap(functionMap, jarName, dfhEntry.getHolder());
+ }
+ }
+
+ List<FunctionInfo> functionList = new
ArrayList<FunctionsIterator.FunctionInfo>(functionMap.values());
+ functionList.sort((FunctionInfo o1, FunctionInfo o2) -> {
+ int result = o1.name.compareTo(o2.name);
+ if (result == 0) {
+ result = o1.signature.compareTo(o2.signature);
+ }
+ if (result == 0) {
+ return o1.returnType.compareTo(o2.returnType);
+ }
+ return result;
+ });
+
+ sortedIterator = functionList.iterator();
+ }
+
+ /**
+ * Populate the map of functionInfo based on the functionSignatureKey for a
given Jar-DrillFunctionHolder
+ * @param functionMap map to populate
+ * @param jarName name of the source jar
+ * @param dfh functionHolder that carries all the registered names and the
signature
+ */
+ private void populateFunctionMap(Map<String, FunctionInfo> functionMap,
String jarName, DrillFuncHolder dfh) {
+ String registeredNames[] = dfh.getRegisteredNames();
+ String signature = dfh.getInputParameters();
+ String returnType = dfh.getReturnType().getMinorType().toString();
+ for (String name : registeredNames) {
+ //Generate a unique key for a function holder as
'functionName#functionSignature'
+ String funcSignatureKey = new
StringBuilder(64).append(name).append('#').append(signature).toString();
+ functionMap.put(funcSignatureKey, new FunctionInfo(name, signature,
returnType, jarName));
+ }
+ }
+
+ @Override
+ public boolean hasNext() {
+ return sortedIterator.hasNext();
+ }
+
+ @Override
+ public FunctionInfo next() {
+ return sortedIterator.next();
+ }
+
+ /**
+ * Representation of an entry in the System table - Functions
+ */
+ public static class FunctionInfo {
+ @NonNullable
+ public final String name;
+ @NonNullable
+ public final String signature;
+ public final String returnType;
Review comment:
StringBuilder capacity was made 64 because the default capacity is 16, which
would almost always be insufficient, forcing a resize. 64 seemed like a
reasonable value. I'll add a comment to explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create a sys.functions table to expose available Drill functions
> ----------------------------------------------------------------
>
> Key: DRILL-3988
> URL: https://issues.apache.org/jira/browse/DRILL-3988
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Jacques Nadeau
> Assignee: Kunal Khatua
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> Create a new sys.functions table that returns a list of all available
> functions.
> Key considerations:
> - one row per name or one per argument set. I'm inclined to latter so people
> can use queries to get to data.
> - we need to create a delineation between user functions and internal
> functions and only show user functions. 'CastInt' isn't something the user
> should be able to see (or run).
> - should we add a description annotation that could be included in the
> sys.functions table?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
