[
https://issues.apache.org/jira/browse/DRILL-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647512#comment-16647512
]
ASF GitHub Bot commented on DRILL-6381:
---------------------------------------
vdiravka commented on a change in pull request #1466: DRILL-6381: Add support
for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r223668951
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/index/IndexConditionInfo.java
##########
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.index;
+
+
+import org.apache.drill.shaded.guava.com.google.common.collect.ImmutableList;
+import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
+import org.apache.drill.shaded.guava.com.google.common.collect.Maps;
+import org.apache.drill.shaded.guava.com.google.common.collect.Sets;
+import org.apache.calcite.plan.RelOptUtil;
+import org.apache.calcite.rex.RexBuilder;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexUtil;
+import org.apache.drill.common.expression.LogicalExpression;
+import org.apache.drill.exec.planner.logical.DrillScanRel;
+import
org.apache.drill.exec.planner.logical.partition.RewriteCombineBinaryOperators;
+import org.apache.calcite.rel.RelNode;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+public class IndexConditionInfo {
+ public final RexNode indexCondition;
+ public final RexNode remainderCondition;
+ public final boolean hasIndexCol;
+
+ public IndexConditionInfo(RexNode indexCondition, RexNode
remainderCondition, boolean hasIndexCol) {
+ this.indexCondition = indexCondition;
+ this.remainderCondition = remainderCondition;
+ this.hasIndexCol = hasIndexCol;
+ }
+
+ public static Builder newBuilder(RexNode condition,
+ Iterable<IndexDescriptor> indexes,
+ RexBuilder builder,
+ RelNode scan) {
+ return new Builder(condition, indexes, builder, scan);
+ }
+
+ public static class Builder {
+ final RexBuilder builder;
+ final RelNode scan;
+ final Iterable<IndexDescriptor> indexes;
+ private RexNode condition;
+
+ public Builder(RexNode condition,
+ Iterable<IndexDescriptor> indexes,
+ RexBuilder builder,
+ RelNode scan
+ ) {
+ this.condition = condition;
+ this.builder = builder;
+ this.scan = scan;
+ this.indexes = indexes;
+ }
+
+ public Builder(RexNode condition,
+ IndexDescriptor index,
+ RexBuilder builder,
+ DrillScanRel scan
+ ) {
+ this.condition = condition;
+ this.builder = builder;
+ this.scan = scan;
+ this.indexes = Lists.newArrayList(index);
+ }
+
+ /**
+ * Get a single IndexConditionInfo in which indexCondition has field on
all indexes in this.indexes
+ * @return
+ */
+ public IndexConditionInfo getCollectiveInfo(IndexLogicalPlanCallContext
indexContext) {
+ Set<LogicalExpression> paths = Sets.newLinkedHashSet();
+ for ( IndexDescriptor index : indexes ) {
+ paths.addAll(index.getIndexColumns());
+ //paths.addAll(index.getNonIndexColumns());
+ }
+ return indexConditionRelatedToFields(Lists.newArrayList(paths),
condition);
+ }
+
+ /*
+ * A utility function to check whether the given index hint is valid.
+ */
+ public boolean isValidIndexHint(IndexLogicalPlanCallContext indexContext) {
+ if (indexContext.indexHint.equals("")) { return false; }
+
+ for ( IndexDescriptor index: indexes ) {
+ if ( indexContext.indexHint.equals(index.getIndexName())) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ /**
+ * Get a map of Index=>IndexConditionInfo, each IndexConditionInfo has the
separated condition and remainder condition.
+ * The map is ordered, so the last IndexDescriptor will have the final
remainderCondition after separating conditions
+ * that are relevant to this.indexes. The conditions are separated on
LEADING index columns.
+ * @return Map containing index{@link IndexDescriptor} and condition
{@link IndexConditionInfo} pairs
+ */
+ public Map<IndexDescriptor, IndexConditionInfo>
getFirstKeyIndexConditionMap() {
+
+ Map<IndexDescriptor, IndexConditionInfo> indexInfoMap =
Maps.newLinkedHashMap();
+
+ RexNode initCondition = condition;
+ for(IndexDescriptor index : indexes) {
Review comment:
formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add capability to do index based planning and execution
> -------------------------------------------------------
>
> Key: DRILL-6381
> URL: https://issues.apache.org/jira/browse/DRILL-6381
> Project: Apache Drill
> Issue Type: New Feature
> Components: Execution - Relational Operators, Query Planning &
> Optimization
> Reporter: Aman Sinha
> Assignee: Aman Sinha
> Priority: Major
> Fix For: 1.15.0
>
>
> If the underlying data source supports indexes (primary and secondary
> indexes), Drill should leverage those during planning and execution in order
> to improve query performance.
> On the planning side, Drill planner should be enhanced to provide an
> abstraction layer which express the index metadata and statistics. Further,
> a cost-based index selection is needed to decide which index(es) are
> suitable.
> On the execution side, appropriate operator enhancements would be needed to
> handle different categories of indexes such as covering, non-covering
> indexes, taking into consideration the index data may not be co-located with
> the primary table, i.e a global index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
