[ 
https://issues.apache.org/jira/browse/DRILL-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650177#comment-16650177
 ] 

ASF GitHub Bot commented on DRILL-6084:
---------------------------------------

arina-ielchiieva commented on issue #1491: DRILL-6084: Show Drill functions in 
WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#issuecomment-429846867
 
 
   @kkhatua what if we add one more parameter to the function template, similar 
to null handling? This parameter will indicate if function is internal or 
public. Default is public. This would allow you to filter out all internal 
functions. You would have to add one more column to the sys.functions table as 
well.
   By the way, does sys.functions table have null handling column? I believe it 
could be useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Expose list of Drill functions for consumption by JavaScript libraries
> ----------------------------------------------------------------------
>
>                 Key: DRILL-6084
>                 URL: https://issues.apache.org/jira/browse/DRILL-6084
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Minor
>              Labels: javascript
>             Fix For: 1.15.0
>
>
> DRILL-5868 introduces SQL highlighter and the auto-complete feature in the 
> web-UI's query editor.
> For the backend Javascript to highlight the keywords correctly as SQL 
> reserved words or functions, it needs a list of all the Drill functions to be 
> already defined in a source JavaScript ( {{../mode-sql.js}} ) .
> While this works well for standard Drill functions, it means that any new 
> function added to Drill needs to be explicitly hard-coded into the file, 
> rather than be programatically discovered and loaded for the library to 
> highlight.
> It would help if this can be done dynamically without contributors having to 
> explicitly alter the script file to add new function names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to