[
https://issues.apache.org/jira/browse/DRILL-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652857#comment-16652857
]
ASF GitHub Bot commented on DRILL-6763:
---------------------------------------
lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r225762550
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
##########
@@ -531,11 +541,42 @@ public JVar declareClassField(String prefix, JType t) {
public JVar declareClassField(String prefix, JType t, JExpression init) {
if (innerClassGenerator != null && hasMaxIndexValue()) {
- return innerClassGenerator.clazz.field(JMod.NONE, t, prefix + index++,
init);
+ return innerClassGenerator.declareClassField(prefix, t, init);
}
return clazz.field(JMod.NONE, t, prefix + index++, init);
}
+ /**
+ * declare a setter method for the argument {@code var}.
+ * argument {@code function} holds the constant value which
+ * returns a value holder must be invoked when the class instance created.
+ * the setter method of innerClassField will be invoked if
innerClassGenerator exists.
+ *
+ * @param var the class member variable
+ * @param function the function holds the constant value
+ * @return the depth of nested class, setter method
+ */
+ public Pair<Integer, JMethod> declareSetterMethod(JVar var,
Function<DrillBuf, ? extends ValueHolder> function) {
+ JMethod setter = clazz.method(JMod.PUBLIC, void.class, "set" +
StringUtils.capitalize(var.name()));
Review comment:
Is It better by NOT declaring the setter function, these fields can be
accessed by reflection directly, so the number of constants in constant pool
can be reduced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Codegen optimization of SQL functions with constant values
> ----------------------------------------------------------
>
> Key: DRILL-6763
> URL: https://issues.apache.org/jira/browse/DRILL-6763
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Codegen
> Affects Versions: 1.14.0
> Reporter: shuifeng lu
> Assignee: shuifeng lu
> Priority: Major
> Fix For: 1.15.0
>
> Attachments: Query1.java, Query2.java, code_compare.png,
> compilation_time.png
>
>
> Codegen class compilation takes tens to hundreds of milliseconds, a class
> cache is hit when generifiedCode of code generator is exactly the same.
> It works fine when UDF only takes columns or symbols, but not efficient when
> one or more parameters in UDF is always distinct from the other.
> Take face recognition for example, the face images are almost distinct from
> each other according to lighting, facial expressions and details.
> It is important to reduce redundant class compilation especially for those
> low latency queries.
> Cache miss rate and metaspace gc can also be reduced by eliminating the
> redundant classes.
> Here is the query to get the persons whose last name is Brunner and hire from
> 1st Jan 1990:
> SELECT full_name, hire_date FROM cp.`employee.json` where last_name =
> 'Brunner' and hire_date >= '1990-01-01 00:00:00.0';
> Now get the persons whose last name is Bernard and hire from 1st Jan 1990.
> SELECT full_name, hire_date FROM cp.`employee.json` where last_name =
> 'Bernard' and hire_date >= '1990-01-01 00:00:00.0';
> Figure !compilation_time.png! shows the compilation time of the generated
> code by the above query in FilterRecordBatch on my laptop
> Figure !code_compare.png! shows the only difference of the generated code
> from the attachments is the last_name value at line 156.
> It is straightforward that the redundant class compilation can be eliminated
> by making the string12 as a member of the class and set the value when the
> instance is created
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
