[
https://issues.apache.org/jira/browse/DRILL-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656765#comment-16656765
]
ASF GitHub Bot commented on DRILL-6785:
---------------------------------------
asfgit closed pull request #1502: DRILL-6785: DataClient is using RootAllocator
in the bootstrap instea…
URL: https://github.com/apache/drill/pull/1502
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java
b/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java
index f222941884e..da6e176d035 100644
---
a/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java
+++
b/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java
@@ -50,7 +50,7 @@ public DataClient(DrillbitEndpoint remoteEndpoint,
DataConnectionConfig config,
super(
DataRpcConfig.getMapping(config.getBootstrapContext().getConfig(),
config.getBootstrapContext().getExecutor()),
- config.getBootstrapContext().getAllocator().getAsByteBufAllocator(),
+ config.getAllocator().getAsByteBufAllocator(),
config.getBootstrapContext().getBitClientLoopGroup(),
RpcType.HANDSHAKE,
BitServerHandshake.class,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DataClient is using RootAllocator in the bootstrap instead of dataPool
> ----------------------------------------------------------------------
>
> Key: DRILL-6785
> URL: https://issues.apache.org/jira/browse/DRILL-6785
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - RPC
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> DataClient currently uses the root allocator in its bootstrap object instead
> of getting the data-pool allocator created for that channel.
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java#L53
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
