[
https://issues.apache.org/jira/browse/DRILL-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657547#comment-16657547
]
ASF GitHub Bot commented on DRILL-6804:
---------------------------------------
Ben-Zvi commented on issue #1508: DRILL-6804: Simplify usage of OperatorPhase
in HashAgg.
URL: https://github.com/apache/drill/pull/1508#issuecomment-431523825
I don't understand the purpose of this Jira - the changed code does not look
simpler than the original. E.g., is was much simpler to read `is2ndPhase`
than now `popConfig.getAggPhase().isSecondPhase()` .
The enum `OperatorPhase` is not adding any functionality. The only issue
is the debug string `getPhaseName()` which can be implemented as a private one
line method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify Usage of OperatorPhase in HashAgg Template
> ---------------------------------------------------
>
> Key: DRILL-6804
> URL: https://issues.apache.org/jira/browse/DRILL-6804
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
