[
https://issues.apache.org/jira/browse/DRILL-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659766#comment-16659766
]
ASF GitHub Bot commented on DRILL-6715:
---------------------------------------
Ben-Zvi commented on a change in pull request #1507: DRILL-6715: Update
descriptions for System Options table
URL: https://github.com/apache/drill/pull/1507#discussion_r227160548
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -115,25 +116,34 @@ private ExecConstants() {
// Hash Join Options
public static final String HASHJOIN_HASHTABLE_CALC_TYPE_KEY =
"exec.hashjoin.hash_table_calc_type";
- public static final StringValidator HASHJOIN_HASHTABLE_CALC_TYPE = new
StringValidator(HASHJOIN_HASHTABLE_CALC_TYPE_KEY, null);
+ public static final StringValidator HASHJOIN_HASHTABLE_CALC_TYPE = new
StringValidator(HASHJOIN_HASHTABLE_CALC_TYPE_KEY,
Review comment:
This is basically an internal option with two values. But check if @ilooner
thinks that this change is useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update descriptions for System Options table
> --------------------------------------------
>
> Key: DRILL-6715
> URL: https://issues.apache.org/jira/browse/DRILL-6715
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.14.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.15.0
>
>
> With introduction of DRILL-5735 , the descriptions for about half the system
> options still remain missing.
> This Jira is to track that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
