[
https://issues.apache.org/jira/browse/DRILL-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660506#comment-16660506
]
ASF GitHub Bot commented on DRILL-6810:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1509: DRILL-6810:
Disable NULL_IF_NULL NullHandling for functions with Comp…
URL: https://github.com/apache/drill/pull/1509#discussion_r227345538
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MappifyUtility.java
##########
@@ -38,22 +38,29 @@
public static final String fieldValue = "value";
public static DrillBuf mappify(FieldReader reader, BaseWriter.ComplexWriter
writer, DrillBuf buffer, String caller) {
- // Currently we expect single map as input
- if (DataMode.REPEATED == reader.getType().getMode() ||
!(reader.getType().getMinorType() == TypeProtos.MinorType.MAP)) {
+ // Currently we expect single map or null as input
+ if (reader.getType().getMode() == DataMode.REPEATED
+ || (reader.isSet() && reader.getType().getMinorType() !=
TypeProtos.MinorType.MAP)) {
throw new DrillRuntimeException("kvgen function only supports Simple
maps as input");
}
BaseWriter.ListWriter listWriter = writer.rootAsList();
listWriter.startList();
BaseWriter.MapWriter mapWriter = listWriter.map();
+ if (!reader.isSet()) {
Review comment:
We can init `BaseWriter.MapWriter mapWriter = listWriter.map();` after null
check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Disable NULL_IF_NULL NullHandling for functions with ComplexWriter
> ------------------------------------------------------------------
>
> Key: DRILL-6810
> URL: https://issues.apache.org/jira/browse/DRILL-6810
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently NullHandling.NULL_IF_NULL is allowed for UDFs with @Output of type
> org.apache.drill.exec.vector.complex.writer.BaseWriter.ComplexWriter but no
> null handling is performed for the kind of functions which leads to
> confusion. The problem is ComplexWriter holds list/map values and Drill does
> not yet support NULL values for the types (there is an issue to allow null
> maps/lists in [DRILL-4824|https://issues.apache.org/jira/browse/DRILL-4824]).
> For such functions support for NULL_IF_NULL will be disabled, as it is done
> for aggregate functions, and NullHandling.INTERNAL should be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
