[
https://issues.apache.org/jira/browse/DRILL-6792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673784#comment-16673784
]
ASF GitHub Bot commented on DRILL-6792:
---------------------------------------
sohami commented on a change in pull request #1504: DRILL-6792: Find the right
probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r230527876
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java
##########
@@ -159,18 +158,22 @@ BufferAllocator getNewChildAllocator(final String
operatorName,
@Override
void close();
-
- /**
- * @return
- */
- RuntimeFilterSink getRuntimeFilterSink();
-
/**
* add a RuntimeFilter when the RuntimeFilter receiver belongs to the same
MinorFragment
* @param runtimeFilter
*/
public void addRuntimeFilter(RuntimeFilterWritable runtimeFilter);
+ public RuntimeFilterWritable getRuntimeFilter();
+
+ /**
+ * get the RuntimeFilter with a blocking wait, if the waiting option is
enabled
+ * @param maxWaitTime
+ * @param timeUnit
+ * @return
Review comment:
add `description` for `return` tag otherwise there is warnings for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Find the right probe side fragment to any storage plugin
> --------------------------------------------------------
>
> Key: DRILL-6792
> URL: https://issues.apache.org/jira/browse/DRILL-6792
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: weijie.tong
> Assignee: weijie.tong
> Priority: Major
> Fix For: 1.15.0
>
>
> The current implementation of JPPD to find the probe side wrapper depends on
> the GroupScan's digest. But there's no promise the GroupScan's digest will
> not be changed since it is attached to the RuntimeFilterDef by different
> storage plugin implementation logic.So here we assign a unique identifier to
> the RuntimeFilter operator, and find the right probe side fragment wrapper by
> the runtime filter identifier at the RuntimeFilterRouter class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
