[ 
https://issues.apache.org/jira/browse/DRILL-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673915#comment-16673915
 ] 

weijie.tong commented on DRILL-6825:
------------------------------------

Thanks for your advice [~ben-zvi]. I am evaluating the hash function choosing 
to different data types , data size, hash code size by reference the 
ClickHouse's implementation. Your advice about the implementation style sounds 
good to me. So there's no issue about that now. 

I think there's no need to keep hashing compatibility,just need to make the 
choosing strategy is all applied by different parts of Drill's codes like hash 
exchange,  hash aggregate, hash join.  To make hash value by different hash 
functions have the same hash value is not viable.

> Applying different hash function according to data types and data size
> ----------------------------------------------------------------------
>
>                 Key: DRILL-6825
>                 URL: https://issues.apache.org/jira/browse/DRILL-6825
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Codegen
>            Reporter: weijie.tong
>            Priority: Major
>             Fix For: 1.16.0
>
>
> Different hash functions have different performance according to different 
> data types and data size. We should choose a right one to apply not just 
> Murmurhash.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to