[
https://issues.apache.org/jira/browse/DRILL-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681758#comment-16681758
]
ASF GitHub Bot commented on DRILL-3610:
---------------------------------------
vvysotskyi commented on a change in pull request #1528: DRILL-3610: Add
TIMESTAMPADD and TIMESTAMPDIFF functions
URL: https://github.com/apache/drill/pull/1528#discussion_r232334614
##########
File path: exec/java-exec/src/main/codegen/data/MathFunctionTypes.tdd
##########
@@ -67,6 +67,19 @@
{input1: "UInt4", input2: "UInt4", outputType: "UInt4", castType:
"int"},
{input1: "UInt8", input2: "UInt8", outputType: "UInt8", castType:
"long"}
]
- }
+ },
+ {className: "DivideInt", funcName: "/int", op: "/", types: [
Review comment:
Yes, these UDFs were used in one of the previous version of the fix, so now
they can be removed. Thanks for pointing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TimestampAdd/Diff (SQL_TSI_) functions
> --------------------------------------
>
> Key: DRILL-3610
> URL: https://issues.apache.org/jira/browse/DRILL-3610
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Reporter: Andries Engelbrecht
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> Add TimestampAdd and TimestampDiff (SQL_TSI) functions for year, quarter,
> month, week, day, hour, minute, second.
> Examples
> SELECT CAST(TIMESTAMPADD(SQL_TSI_QUARTER,1,Date('2013-03-31'), SQL_DATE) AS
> `column_quarter`
> FROM `table_in`
> HAVING (COUNT(1) > 0)
> SELECT `table_in`.`datetime` AS `column1`,
> `table`.`Key` AS `column_Key`,
> TIMESTAMPDIFF(SQL_TSI_MINUTE,to_timestamp('2004-07-04',
> 'yyyy-MM-dd'),`table_in`.`datetime`) AS `sum_datediff_minute`
> FROM `calcs`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
