[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688829#comment-16688829
]
ASF GitHub Bot commented on DRILL-6668:
---------------------------------------
kkhatua commented on a change in pull request #1543: DRILL-6668: In Web UI,
highlight options that are not default values
URL: https://github.com/apache/drill/pull/1543#discussion_r234052643
##########
File path: exec/java-exec/src/main/resources/rest/options.ftl
##########
@@ -21,6 +21,26 @@
<#macro page_head>
<script type="text/javascript" language="javascript"
src="/static/js/jquery.dataTables-1.10.16.min.js"> </script>
<script type="text/javascript" language="javascript"
src="/static/js/dataTables.colVis-1.1.0.min.js"></script>
+ <script>
+ //Alter System Values
+ function alterSysOption(optionName, optionValue, optionKind) {
+ $.post("/option/"+optionName, {kind: optionKind, name: optionName,
value: optionValue}, function () {
+ location.reload(true);
+ });
+ }
+
+ //Read Values and apply
+ function alterSysOptionUsingId(optionRawName) {
Review comment:
Ok. Will do that and run the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> In Web Console, highlight options that are different from default values
> ------------------------------------------------------------------------
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.14.0
> Reporter: Paul Rogers
> Assignee: Kunal Khatua
> Priority: Minor
> Fix For: 1.15.0, 1.16.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
