[ 
https://issues.apache.org/jira/browse/DRILL-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700956#comment-16700956
 ] 

ASF GitHub Bot commented on DRILL-6864:
---------------------------------------

Ben-Zvi closed pull request #1555: DRILL-6864: Upgrade the git-commit-id plugin 
to 2.2.5
URL: https://github.com/apache/drill/pull/1555
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index bd512c4d6f7..6f80581ae57 100644
--- a/pom.xml
+++ b/pom.xml
@@ -527,7 +527,7 @@
       <plugin>
         <groupId>pl.project13.maven</groupId>
         <artifactId>git-commit-id-plugin</artifactId>
-        <version>2.1.9</version>
+        <version>2.2.5</version>
         <executions>
           <execution>
             <id>for-jars</id>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Root POM: Update the git-commit-id plugin
> -----------------------------------------
>
>                 Key: DRILL-6864
>                 URL: https://issues.apache.org/jira/browse/DRILL-6864
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.14.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.15.0
>
>
>    The Maven git-commit-id plugin is of version 2.1.9, which is 4.5 years 
> old. Executing this plugin seems to take a significant portion of the mvn 
> build time. Newer versions run more than twice as fast (see below).
>   Suggestion: Upgrade to the latest (2.2.5), to shorten the Drill mvn build 
> time.
> Here are the run times with our *current (2.1.9)* version:
> {code:java}
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [25.320s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [24.255s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [22.821s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [32.889s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [34.557s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [26.085s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [46.135s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [72.811s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [45.956s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [18.223s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [19.841s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [50.146s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [30.993s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [32.839s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [33.852s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [23.562s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [25.333s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [24.737s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [19.098s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [46.245s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [40.350s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [34.610s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [78.756s]
> [INFO]   git-commit-id-plugin:revision (for-source-tarball) ....... [52.551s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [10.940s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [24.573s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [24.404s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [43.501s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [25.041s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [39.149s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [40.310s]
> {code}
> And here are the run times with a newer (2.2.4) version:
> {code:java}
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [6.964s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [18.732s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [7.441s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [8.146s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [6.404s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [7.837s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [9.788s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [9.136s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [19.607s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [9.289s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [8.046s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [8.268s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [7.868s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [10.750s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [8.558s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [11.267s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [15.696s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [9.446s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [6.187s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [24.806s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [14.591s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [16.409s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [12.041s]
> [INFO]   git-commit-id-plugin:revision (for-source-tarball) ....... [6.177s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [7.734s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [6.384s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [11.153s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [12.804s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [8.206s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [12.552s]
> [INFO]   git-commit-id-plugin:revision (for-jars) ................. [19.592s]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to