[ 
https://issues.apache.org/jira/browse/DRILL-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711644#comment-16711644
 ] 

ASF GitHub Bot commented on DRILL-6751:
---------------------------------------

vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to 
version 21
URL: https://github.com/apache/drill/pull/1561#issuecomment-444928201
 
 
   @sohami Thank you for review.
   
   Looks like there is no more need in converting `RuntimeException` to 
`SQLException`, it was resolved in Avatica-1.9.0 for a long time ago, see 
[CALCITE-1408](https://issues.apache.org/jira/browse/CALCITE-1408)
   For now it is 
[`SQLDataException`](https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java#L367)
 (inheritor of `java.sql.SQLException`).
   Therefore no need to have WrappedAccessor in Drill.
   
   I have updated it and squashed "Changes after the review" with the last 
commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade Apache parent POM to version 21
> ---------------------------------------
>
>                 Key: DRILL-6751
>                 URL: https://issues.apache.org/jira/browse/DRILL-6751
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Tools, Build & Test
>    Affects Versions: 1.14.0
>            Reporter: Arina Ielchiieva
>            Assignee: Vitalii Diravka
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.15.0
>
>
> Upgrade Apache parent POM to version 21



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to