[
https://issues.apache.org/jira/browse/DRILL-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713751#comment-16713751
]
ASF GitHub Bot commented on DRILL-6887:
---------------------------------------
vdiravka commented on a change in pull request #1566: DRILL-6887: Fix
FunctionInitializerTest.init() failure
URL: https://github.com/apache/drill/pull/1566#discussion_r240012782
##########
File path: exec/java-exec/src/test/resources/drill-udf/pom.xml
##########
@@ -28,6 +28,8 @@
<version>1.0</version>
<properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
Review comment:
After removing these properties the [default
values](https://github.com/apache/maven-compiler-plugin/blob/875947802d28bcf8348eb634985c0512a790170a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L169)
for them will be 1.6:
> Since `maven-compiler-plugin` 3.8.0 the default value has changed from 1.5
to 1.6
Even with explicit 1.6 values for `source` and `target` properties the tests
pass, but these are not the right versions for current Drill version.
According to [Maven
docs](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html)
we need to specify the properties for Java8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix FunctionInitializerTest.init() failure
> ------------------------------------------
>
> Key: DRILL-6887
> URL: https://issues.apache.org/jira/browse/DRILL-6887
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.14.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Blocker
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> DRILL-6751 introduces unit test failures for jdk9 and above.
> {code:java}
> [ERROR] Failures:
> [ERROR] FunctionInitializerTest.init:64 Build should be successful.
> expected:<0> but was:<1>
> {code}
> [https://circleci.com/gh/vdiravka/drill/154]
> The root cause is
> [drill-udf.pom|https://github.com/apache/drill/blob/master/exec/java-exec/src/test/resources/drill-udf/pom.xml]
> doesn't inherit drill root pom file. Therefore all properties are individual
> for this pom file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
