[
https://issues.apache.org/jira/browse/DRILL-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800519#comment-16800519
]
ASF GitHub Bot commented on DRILL-7051:
---------------------------------------
vdiravka commented on pull request #1681: DRILL-7051: Upgrade jetty
URL: https://github.com/apache/drill/pull/1681#discussion_r268551237
##########
File path: pom.xml
##########
@@ -85,6 +85,7 @@
<reflections.version>0.9.10</reflections.version>
<avro.version>1.8.2</avro.version>
<metrics.version>4.0.2</metrics.version>
+ <jetty.version>9.4.15.v20190215</jetty.version>
Review comment:
Finally jetty 9.3 is chosen for Drill.
Jetty dependencies are used in `java-exec pom.xml`, but I've left versions
control in `dependencyManagement` block of root POM to avoid picking invalid
jetty version by maven, in case when some libs will have other version.
For instance we can't exclude jetty from `hadoop-common` and `hbase`
dependencies. But they have different jetty minor versions:
[9.3.24.v20180605](https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L38)
for Hadoop
[9.3.19.v20170502](https://github.com/apache/hbase/blob/rel/2.1.0/pom.xml#L1352)
for HBase 2.1 and
[9.3.25.v20180904](https://github.com/apache/hbase/blob/master/pom.xml#L1529)
for master HBase version.
I didn't find any API compatibility differences between these jetty minor
versions (only 9.4 has it).
Possibly in future we can consider shade Jetty version in Drill,
[DRILL-7135](https://issues.apache.org/jira/browse/DRILL-7135). Not sure that
is necessary for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade jetty
> --------------
>
> Key: DRILL-7051
> URL: https://issues.apache.org/jira/browse/DRILL-7051
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.15.0
> Reporter: Veera Naranammalpuram
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.16.0
>
>
> Is Drill using a version of jetty web server that's really old? The jar's
> suggest it's using jetty 9.1 that was built sometime in 2014?
> {noformat}
> -rw-r--r-- 1 veeranaranammalpuram staff 15988 Nov 20 2017
> jetty-continuation-9.1.1.v20140108.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 103288 Nov 20 2017
> jetty-http-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 101519 Nov 20 2017
> jetty-io-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 95906 Nov 20 2017
> jetty-security-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 401593 Nov 20 2017
> jetty-server-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 110992 Nov 20 2017
> jetty-servlet-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 119215 Nov 20 2017
> jetty-servlets-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 341683 Nov 20 2017
> jetty-util-9.1.5.v20140505.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 38707 Dec 21 15:42
> jetty-util-ajax-9.3.19.v20170502.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 111466 Nov 20 2017
> jetty-webapp-9.1.1.v20140108.jar
> -rw-r--r-- 1 veeranaranammalpuram staff 41763 Nov 20 2017
> jetty-xml-9.1.1.v20140108.jar {noformat}
> This version is shown as deprecated:
> [https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html#d0e203]
> Opening this to upgrade jetty to the latest stable supported version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
