[
https://issues.apache.org/jira/browse/DRILL-7117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804473#comment-16804473
]
ASF GitHub Bot commented on DRILL-7117:
---------------------------------------
amansinha100 commented on pull request #1715: DRILL-7117: Support creation of
equi-depth histogram for selected dat…
URL: https://github.com/apache/drill/pull/1715#discussion_r270235751
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java
##########
@@ -62,10 +62,15 @@
public enum STATS_VERSION {V0, V1};
// The current version
public static final STATS_VERSION CURRENT_VERSION = STATS_VERSION.V1;
+ // 10 histogram buckets (TODO: can make this configurable later)
+ public static final int NUM_HISTOGRAM_BUCKETS = 10;
Review comment:
I picked 10 buckets because that's what Postgres uses. I will try and check
any others (let me know if you know of other defaults). Also, in the JSON
stats file we want to keep the amount of serialized output small enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support creation of histograms for numeric data types (except Decimal) and
> date/time/timestamp
> ----------------------------------------------------------------------------------------------
>
> Key: DRILL-7117
> URL: https://issues.apache.org/jira/browse/DRILL-7117
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Query Planning & Optimization
> Reporter: Aman Sinha
> Assignee: Aman Sinha
> Priority: Major
> Fix For: 1.16.0
>
>
> This JIRA is specific to creating histograms for numeric data types: INT,
> BIGINT, FLOAT4, FLOAT8 and their corresponding nullable/non-nullable
> versions. Additionally, since DATE/TIME/TIMESTAMP are internally stored as
> longs, we should allow the same numeric type histogram creation for these
> data types as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
