[
https://issues.apache.org/jira/browse/DRILL-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807260#comment-16807260
]
ASF GitHub Bot commented on DRILL-7147:
---------------------------------------
paul-rogers commented on issue #1724: DRILL-7147: Source order of drill-env.sh
and distrib-env.sh should be swapped
URL: https://github.com/apache/drill/pull/1724#issuecomment-478780266
Please see note in the JIRA ticket. Current behavior is correct. I suspect
that the issue is with one specific variable. Which one cause the issue that
this is trying to fix?
I believe that there are DoY unit tests that attempt to verify correct
behavior (I remember writing them.) This fix would break those tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Source order of "drill-env.sh" and "distrib-env.sh" should be swapped
> ---------------------------------------------------------------------
>
> Key: DRILL-7147
> URL: https://issues.apache.org/jira/browse/DRILL-7147
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 1.15.0
> Reporter: Hao Zhu
> Assignee: Abhishek Girish
> Priority: Minor
> Fix For: 1.16.0
>
>
> In bin/drill-config.sh, the description of the source order is:
> {code:java}
> # Variables may be set in one of four places:
> #
> # Environment (per run)
> # drill-env.sh (per site)
> # distrib-env.sh (per distribution)
> # drill-config.sh (this file, Drill defaults)
> #
> # Properties "inherit" from items lower on the list, and may be "overridden"
> by items
> # higher on the list. In the environment, just set the variable:
> {code}
> However actually bin/drill-config.sh sources drill-env.sh firstly, and then
> distrib-env.sh.
> {code:java}
> drillEnv="$DRILL_CONF_DIR/drill-env.sh"
> if [ -r "$drillEnv" ]; then
> . "$drillEnv"
> fi
> ...
> distribEnv="$DRILL_CONF_DIR/distrib-env.sh"
> if [ -r "$distribEnv" ]; then
> . "$distribEnv"
> else
> distribEnv="$DRILL_HOME/conf/distrib-env.sh"
> if [ -r "$distribEnv" ]; then
> . "$distribEnv"
> fi
> fi
> {code}
> We need to swap the source order of drill-env.sh and distrib-env.sh.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
