[
https://issues.apache.org/jira/browse/DRILL-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813174#comment-16813174
]
ASF GitHub Bot commented on DRILL-7160:
---------------------------------------
vvysotskyi commented on issue #1742: DRILL-7160: e.q.max_rows QUERY-level
option shown even if not set
URL: https://github.com/apache/drill/pull/1742#issuecomment-481175705
@kkhatua, `exec.query.max_rows` query level option should be present in
query profile only for the case when auto-limit is applied or can be applied,
but currently, it is present even for the case when the non-select query is
submitted and `exec.query.max_rows` is set to non-zero value. Please fix this
case and verify that other corner cases are handled correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> exec.query.max_rows QUERY-level options are shown on Profiles tab
> -----------------------------------------------------------------
>
> Key: DRILL-7160
> URL: https://issues.apache.org/jira/browse/DRILL-7160
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Kunal Khatua
> Priority: Blocker
> Fix For: 1.16.0
>
>
> As [~arina] has noticed, option {{exec.query.max_rows}} is shown on Web UI's
> Profiles even when it was not set explicitly. The issue is because the option
> is being set on the query level internally.
> From the code, looks like it is set in
> {{DrillSqlWorker.checkAndApplyAutoLimit()}}, and perhaps a check whether the
> value differs from the existing one should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
