[
https://issues.apache.org/jira/browse/DRILL-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816426#comment-16816426
]
ASF GitHub Bot commented on DRILL-7169:
---------------------------------------
sohami commented on pull request #1746: DRILL-7169: Rename drill-root
ArtifactID to apache-drill
URL: https://github.com/apache/drill/pull/1746#discussion_r274976052
##########
File path: distribution/pom.xml
##########
@@ -390,71 +390,71 @@
<directory>/opt/drill</directory>
<sources>
<source>
-
<location>target/apache-drill-${project.version}/apache-drill-${project.version}/git.properties</location>
+
<location>target/${project.parent.artifactId}-${project.version}/${project.parent.artifactId}-${project.version}/git.properties</location>
Review comment:
all the `<location>target/...` can be replaced by
`<location>${project.build.directory}/....`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rename drill-root ArtifactID to apache-drill
> --------------------------------------------
>
> Key: DRILL-7169
> URL: https://issues.apache.org/jira/browse/DRILL-7169
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.15.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Minor
> Fix For: Future
>
>
> Rename {{drill-root}} root POM ArtifactID to {{apache-drill, see:}}
> {{[https://github.com/apache/drill/blob/master/pom.xml#L32]}}
> Most of all Apache projects use short project name as artifactId.
> Rename it to {{apache-drill}} allow to use it as variable for drill build
> process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
