[
https://issues.apache.org/jira/browse/DRILL-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824368#comment-16824368
]
ASF GitHub Bot commented on DRILL-6974:
---------------------------------------
vvysotskyi commented on pull request #1763: DRILL-6974: Add possibility to view
option value via SET command
URL: https://github.com/apache/drill/pull/1763#discussion_r277789557
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandlerTest.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.sql.handlers;
+
+import org.apache.drill.categories.SqlTest;
+import org.apache.drill.exec.ExecConstants;
+import org.apache.drill.exec.compile.ClassCompilerSelector;
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterTest;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category(SqlTest.class)
+public class SetOptionHandlerTest extends ClusterTest {
+
+ @BeforeClass
+ public static void setup() throws Exception {
+ startCluster(ClusterFixture.builder(dirTestWatcher).maxParallelization(1));
+ }
+
+ @Test
+ public void testSimpleSetQuery() throws Exception {
+ String defaultValue = client.queryBuilder()
+ .sql("SELECT val from sys.options where name = '%s' limit 1",
+ ClassCompilerSelector.JAVA_COMPILER_DEBUG_OPTION)
+ .singletonString();
+
+ boolean newValue = !Boolean.valueOf(defaultValue);
+ try {
+ client.alterSession(ClassCompilerSelector.JAVA_COMPILER_DEBUG_OPTION,
newValue);
+
+ String changedValue = client.queryBuilder()
+ .sql("SELECT val from sys.options where name = '%s' limit 1",
+ ClassCompilerSelector.JAVA_COMPILER_DEBUG_OPTION)
+ .singletonString();
+
+ Assert.assertEquals(String.valueOf(newValue), changedValue);
+ Assert.assertNotEquals(defaultValue, changedValue);
Review comment:
This assertion is redundant, the first one handles such case:
`newValue==changedValue&&newValue!=defaultValue->changedValue!=defaultValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SET option command
> ------------------
>
> Key: DRILL-6974
> URL: https://issues.apache.org/jira/browse/DRILL-6974
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Affects Versions: 1.15.0
> Reporter: benj
> Assignee: Dmytriy Grinchenko
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> It's currently possible to define options with the SQL command SET
> {code:java}
> ALTER SESSION SET `drill.exec.hashagg.fallback.enabled` = true;
> {code}
> But it's not possible to simply visualize the current value of one option
> with SHOW, we have to query like
> {code:java}
> SELECT * FROM sys.options WHERE `name` =
> 'drill.exec.hashagg.fallback.enabled';
> {code}
> Why not allow a simple
> {code:java}
> SET `drill.exec.hashagg.fallback.enabled`;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
