[
https://issues.apache.org/jira/browse/DRILL-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835409#comment-16835409
]
ASF GitHub Bot commented on DRILL-4782:
---------------------------------------
ihuzenko commented on pull request #1784: DRILL-4782 / DRILL-7139: Fix cast and
arithmetic for DayInterval
URL: https://github.com/apache/drill/pull/1784#discussion_r281947995
##########
File path:
exec/java-exec/src/main/codegen/templates/CastStringTypesToInterval.java
##########
@@ -86,24 +86,35 @@ public void eval() {
org.joda.time.Period period = org.joda.time.Period.parse(input);
<#if type.to == "Interval" || type.to == "NullableInterval">
- out.months = (period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths) + period.getMonths();
+ out.months = period.getYears() *
org.apache.drill.exec.vector.DateUtilities.yearsToMonths + period.getMonths();
out.days = period.getDays();
- out.milliseconds = (period.getHours() *
org.apache.drill.exec.vector.DateUtilities.hoursToMillis) +
- (period.getMinutes() *
org.apache.drill.exec.vector.DateUtilities.minutesToMillis) +
- (period.getSeconds() *
org.apache.drill.exec.vector.DateUtilities.secondsToMillis) +
- (period.getMillis());
+ out.milliseconds = period.getHours() *
org.apache.drill.exec.vector.DateUtilities.hoursToMillis +
+ period.getMinutes() *
org.apache.drill.exec.vector.DateUtilities.minutesToMillis +
+ period.getSeconds() *
org.apache.drill.exec.vector.DateUtilities.secondsToMillis +
+ period.getMillis();
<#elseif type.to == "IntervalDay" || type.to == "NullableIntervalDay">
out.days = period.getDays();
- out.milliseconds = (period.getHours() *
org.apache.drill.exec.vector.DateUtilities.hoursToMillis) +
- (period.getMinutes() *
org.apache.drill.exec.vector.DateUtilities.minutesToMillis) +
- (period.getSeconds() *
org.apache.drill.exec.vector.DateUtilities.secondsToMillis) +
- (period.getMillis());
+ long millis = period.getHours() * (long)
org.apache.drill.exec.vector.DateUtilities.hoursToMillis +
+ period.getMinutes() * (long)
org.apache.drill.exec.vector.DateUtilities.minutesToMillis +
+ period.getSeconds() * (long)
org.apache.drill.exec.vector.DateUtilities.secondsToMillis +
+ period.getMillis();
+
+ // Subtracts all full days from millis
+ if (millis >
org.apache.drill.exec.vector.DateUtilities.daysToStandardMillis - 1) {
Review comment:
```suggestion
if (millis >=
org.apache.drill.exec.vector.DateUtilities.daysToStandardMillis) {
// Extract days from millis and add them to out.days
int daysFromMillis = (int) (millis /
org.apache.drill.exec.vector.DateUtilities.daysToStandardMillis);
millis -= daysFromMillis *
org.apache.drill.exec.vector.DateUtilities.daysToStandardMillis;
out.days += daysFromMillis;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TO_TIME function cannot separate time from date time string
> -----------------------------------------------------------
>
> Key: DRILL-4782
> URL: https://issues.apache.org/jira/browse/DRILL-4782
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.6.0, 1.7.0
> Environment: CentOS 7
> Reporter: Matt Keranen
> Assignee: Dmytriy Grinchenko
> Priority: Minor
> Fix For: 1.17.0
>
>
> TO_TIME('2016-03-03 00:00', ''yyyy-MM-dd HH:mm') returns "05:14:46.656"
> instead of the expected "00:00:00"
> Adding and additional split does work as expected: TO_TIME(SPLIT('2016-03-03
> 00:00', ' ')[1], 'HH:mm')
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
