[
https://issues.apache.org/jira/browse/DRILL-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845639#comment-16845639
]
ASF GitHub Bot commented on DRILL-7196:
---------------------------------------
arina-ielchiieva commented on pull request #1794: DRILL-7196: Queries are still
runnable on disabled plugins
URL: https://github.com/apache/drill/pull/1794#discussion_r286353432
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/store/TestDisabledPlugin.java
##########
@@ -58,10 +56,10 @@ public static void restore() throws Exception {
public void testDisabledPluginQuery() throws Exception {
try {
run("SELECT * FROM cp.`employee.json` LIMIT 10");
- fail("Query should have failed!");
+ Assert.fail("Query should have failed!");
Review comment:
In Drill unit tests we usually use static import for assert methods. Please
revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Queries are still runnable on disabled plugins
> ----------------------------------------------
>
> Key: DRILL-7196
> URL: https://issues.apache.org/jira/browse/DRILL-7196
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.12.0
> Reporter: Dmytriy Grinchenko
> Assignee: Dmytriy Grinchenko
> Priority: Major
> Fix For: 1.17.0
>
>
> The issue were partially addressed with the DRILL-6732 task. However when
> issuing select request with full path to the table, select still able to
> process it regardless of the plugin state:
> {code}
> 0: jdbc:drill:zk=local> select * from `mongo.my_binaries`.`master.files`;
> +-----------------------------------+------------+
> | md5 | chunkSize |
> +-----------------------------------+------------+
> | 4e30dc965bb8aa064af4f2a9608fa7ae | 261120 |
> | b223e44347e63fcae296e8432755e07c | 261120 |
> | 2720c5e10e739142d1b28996349a1d7e | 261120 |
> +-----------------------------------+------------+
> 0: jdbc:drill:zk=local> show schemas;
> +---------------------+
> | SCHEMA_NAME |
> +---------------------+
> | cp.default |
> | dfs.default |
> | dfs.root |
> | dfs.test |
> | dfs.tmp |
> | hive.default |
> | information_schema |
> | sys |
> +---------------------+
> 8 rows selected (0.127 seconds)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
