[
https://issues.apache.org/jira/browse/DRILL-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846316#comment-16846316
]
ASF GitHub Bot commented on DRILL-7204:
---------------------------------------
kkhatua commented on issue #1788: DRILL-7204: Add proper validation when
creating plugin
URL: https://github.com/apache/drill/pull/1788#issuecomment-495022383
Sorry. Took me a while to get around to trying this out. I tried breaking it
and it looks robust enough. Any malformed calls via REST APIs would need
server-side checks, but that would involve much more work and I don't think it
is critical.
Nice work, @agozhiy
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add proper validation when creating plugin
> ------------------------------------------
>
> Key: DRILL-7204
> URL: https://issues.apache.org/jira/browse/DRILL-7204
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Arina Ielchiieva
> Assignee: Anton Gozhiy
> Priority: Major
> Fix For: 1.17.0
>
> Attachments: alert.JPG, new_plugin.png
>
>
> 1. Currently there is no failure when user attempts to create plugin without
> name. Screenshot attached. I think we need proper plugin name validation when
> creating plugin.
> 2. When disabling and deleting plugin, alerts are used. Its better to use
> more user friendly message window. Screenshot attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
